Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created separate group verification for digitisation form #294

Merged
merged 10 commits into from
Sep 11, 2024
Merged

Created separate group verification for digitisation form #294

merged 10 commits into from
Sep 11, 2024

Conversation

Sujanadh
Copy link
Contributor

@Sujanadh Sujanadh commented Sep 6, 2024

Updates

  • avoided creating groups in choice sheets
  • created separate group for digitisation form and custom form as verification group and survey group

@Sujanadh Sujanadh requested a review from spwoodcock September 6, 2024 04:46
@Sujanadh Sujanadh self-assigned this Sep 6, 2024
@github-actions github-actions bot added the enhancement New feature or request label Sep 6, 2024
@Sujanadh Sujanadh marked this pull request as draft September 9, 2024 03:57
@Sujanadh
Copy link
Contributor Author

Sujanadh commented Sep 9, 2024 •
edited
Loading

  • added free text comment at the end of verification form
  • updated version in settings to current timestamp

@Sujanadh Sujanadh marked this pull request as ready for review September 9, 2024 05:57
@Sujanadh
Copy link
Contributor Author

  • edited xlsx form to allow to create entity for new feature point
  • added a question if user wants to add a new feature point
  • if yes then avoid building exists question and continue survey form
  • if no user selects existing feature and continue form
  • uuid is auto generated when new feature is located and its point is populated as a geometry along with task_id and status is updated to 2

@Sujanadh
Copy link
Contributor Author

  • set the version column type to str to avoid warning like
    FutureWarning: Setting an item of incompatible dtype is deprecated and will raise in a future error of pandas. Value '2024-09-11 04:09:53' has dtype incompatible with float64, please explicitly cast to a compatible dtype first.

@spwoodcock spwoodcock merged commit 00ee868 into hotosm:main Sep 11, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spwoodcock spwoodcock spwoodcock approved these changes

Assignees

@Sujanadh Sujanadh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sujanadh @spwoodcock